[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] build: correct gas --noexecstack check



commit d1f6a58dfdc508c43a51c1865c826d519bf16493
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Mon Aug 14 09:58:19 2023 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Mon Aug 14 09:58:19 2023 +0200

    build: correct gas --noexecstack check
    
    The check was missing an escape for the inner $, thus breaking things
    in the unlikely event that the underlying assembler doesn't support this
    option.
    
    Fixes: 62d22296a95d ("build: silence GNU ld warning about executable 
stacks")
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
---
 xen/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/Makefile b/xen/Makefile
index c1738dbbde..f57e5a596c 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -405,7 +405,7 @@ endif
 
 AFLAGS += -D__ASSEMBLY__
 
-$(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack)
+$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack)
 
 LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments
 
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.