[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen stable-4.17] tools/vchan: Fix -Wsingle-bit-bitfield-constant-conversion



commit 052a8d24bc670ab6503e21dfd2fb8bccfc22aa73
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Tue Aug 8 14:53:42 2023 +0100
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Tue Aug 22 14:36:53 2023 +0100

    tools/vchan: Fix -Wsingle-bit-bitfield-constant-conversion
    
    Gitlab reports:
    
      node.c:158:17: error: implicit truncation from 'int' to a one-bit wide 
bit-field changes value from 1 to -1 
[-Werror,-Wsingle-bit-bitfield-constant-conversion]
    
            ctrl->blocking = 1;
                           ^ ~
      1 error generated.
      make[4]: *** 
[/builds/xen-project/people/andyhhp/xen/tools/vchan/../../tools/Rules.mk:188: 
node.o] Error 1
    
    In Xen 4.18, this was fixed with c/s 99ab02f63ea8 ("tools: convert bitfields
    to unsigned type") but this is an ABI change which can't be backported.
    
    Swich 1 for -1 to provide a minimally invasive way to fix the build.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 tools/vchan/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/vchan/node.c b/tools/vchan/node.c
index f1638f013d..a28293b720 100644
--- a/tools/vchan/node.c
+++ b/tools/vchan/node.c
@@ -155,7 +155,7 @@ int main(int argc, char **argv)
                perror("libxenvchan_*_init");
                exit(1);
        }
-       ctrl->blocking = 1;
+       ctrl->blocking = -1;
 
        srand(seed);
        fprintf(stderr, "seed=%d\n", seed);
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.17



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.