[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] xen/arm: ffa: fix guest map RX/TX error code



commit 6242d1b74538c904ac28116b07a22d9cc6bf2542
Author:     Jens Wiklander <jens.wiklander@xxxxxxxxxx>
AuthorDate: Mon Sep 4 16:58:14 2023 +0200
Commit:     Stefano Stabellini <stefano.stabellini@xxxxxxx>
CommitDate: Wed Sep 6 17:36:50 2023 -0700

    xen/arm: ffa: fix guest map RX/TX error code
    
    FFA_RXTX_MAP is currently limited to mapping only one 4k page for each
    RX and TX buffer. If a guest tries to map more than one page, an error
    is returned. Until this patch, we have been using FFA_RET_NOT_SUPPORTED.
    However, that error code is reserved in the FF-A specification to report
    that the function is not implemented. Of all the other defined error
    codes, the least bad is FFA_RET_INVALID_PARAMETERS, so use that instead.
    
    Fixes: 38d81e7ccb11 ("xen/arm: ffa: support mapping guest RX/TX buffers")
    Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
    Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
---
 xen/arch/arm/tee/ffa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
index 802b2dbb1d..183528d133 100644
--- a/xen/arch/arm/tee/ffa.c
+++ b/xen/arch/arm/tee/ffa.c
@@ -706,7 +706,7 @@ static uint32_t handle_rxtx_map(uint32_t fid, register_t 
tx_addr,
     {
         printk(XENLOG_ERR "ffa: RXTX_MAP: error: %u pages requested (limit 
%u)\n",
                page_count, FFA_MAX_RXTX_PAGE_COUNT);
-        return FFA_RET_NOT_SUPPORTED;
+        return FFA_RET_INVALID_PARAMETERS;
     }
 
     /* Already mapped */
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.