[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] include: make domain_page.h's stubs properly use type-unsafe MFN <-> virt helpers



commit 9227a94e28ade35621402dc25adf86e8c7a47663
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Mon Sep 11 17:30:34 2023 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Mon Sep 11 17:30:34 2023 +0200

    include: make domain_page.h's stubs properly use type-unsafe MFN <-> virt 
helpers
    
    The first of the commits referenced below didn't go far enough, and the
    2nd of them, while trying to close (some of) the gap, wrongly kept using
    the potentially type-safe variant. This is getting in the way of new
    ports preferably not having any type-unsafe private code (and in
    particular not having a need for any overrides in newly introduced
    files).
    
    Fixes: 41c48004d1d8 ("xen/mm: Use __virt_to_mfn in map_domain_page instead 
of virt_to_mfn")
    Fixes: f46b6197344f ("xen: Convert page_to_mfn and mfn_to_page to use 
typesafe MFN")
    Reported-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
---
 xen/include/xen/domain_page.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/include/xen/domain_page.h b/xen/include/xen/domain_page.h
index c4007eac09..0ff5cdd294 100644
--- a/xen/include/xen/domain_page.h
+++ b/xen/include/xen/domain_page.h
@@ -56,11 +56,11 @@ static inline void *__map_domain_page_global(const struct 
page_info *pg)
 #define map_domain_page(mfn)                __mfn_to_virt(mfn_x(mfn))
 #define __map_domain_page(pg)               page_to_virt(pg)
 #define unmap_domain_page(va)               ((void)(va))
-#define domain_page_map_to_mfn(va)          _mfn(virt_to_mfn((unsigned 
long)(va)))
+#define domain_page_map_to_mfn(va)          _mfn(__virt_to_mfn((unsigned 
long)(va)))
 
 static inline void *map_domain_page_global(mfn_t mfn)
 {
-    return mfn_to_virt(mfn_x(mfn));
+    return __mfn_to_virt(mfn_x(mfn));
 }
 
 static inline void *__map_domain_page_global(const struct page_info *pg)
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.