[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] nestedsvm: Remove bogus debug message from nestedsvm_check_intercepts



commit 03fb5f503cb5faa0556b23d594496719ced6a11b
Author:     George Dunlap <george.dunlap@xxxxxxxxx>
AuthorDate: Mon Jan 22 15:32:25 2024 +0000
Commit:     George Dunlap <george.dunlap@xxxxxxxxx>
CommitDate: Mon Feb 26 15:57:56 2024 +0000

    nestedsvm: Remove bogus debug message from nestedsvm_check_intercepts
    
    Changeset ef3e8db8068 ("x86/hvm: Corrections and improvements to
    unhandled vmexit logging") introduced a printk to the default path of
    the switch statement in nestedsvm_check_intercepts(), complaining of
    an unknown exit reason.
    
    Unfortunately, the "core" switch statement which is meant to handle
    all vmexit reasons is in nsvm_vmcb_guest_intercepts_exitcode(); the
    switch statement in nestedsvm_check_intercepts() is only meant to
    superimpose on top of that some special-casing for how to interaction
    between L1 and L0 vmexits.
    
    Remove the printk, and add a comment to prevent future confusion.
    
    Fixes: ef3e8db8068 ("x86/hvm: Corrections and improvements to unhandled 
vmexit logging")
    
    Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/arch/x86/hvm/svm/nestedsvm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c
index ee9602f5c8..e4e01add8c 100644
--- a/xen/arch/x86/hvm/svm/nestedsvm.c
+++ b/xen/arch/x86/hvm/svm/nestedsvm.c
@@ -1294,6 +1294,10 @@ nestedsvm_check_intercepts(struct vcpu *v, struct 
cpu_user_regs *regs,
     ASSERT(vcpu_nestedhvm(v).nv_vmexit_pending == 0);
     is_intercepted = nsvm_vmcb_guest_intercepts_exitcode(v, regs, exitcode);
 
+    /* 
+     * Handle specific interactions between things the guest and host
+     * may both want to intercept
+     */
     switch ( exitcode )
     {
     case VMEXIT_INVALID:
@@ -1349,8 +1353,6 @@ nestedsvm_check_intercepts(struct vcpu *v, struct 
cpu_user_regs *regs,
         /* Always let the guest handle VMMCALL/VMCALL */
         return NESTEDHVM_VMEXIT_INJECT;
     default:
-        gprintk(XENLOG_ERR, "Unexpected nested vmexit: reason %#"PRIx64"\n",
-                exitcode);
         break;
     }
 
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.