[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] common/sched: address a violation of MISRA C Rule 8.7



commit 4b09c30b0f778160523045396f7fff631a24bc1c
Author:     Victor Lira <victorm.lira@xxxxxxx>
AuthorDate: Mon Jul 22 09:37:45 2024 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Mon Jul 22 09:37:45 2024 +0200

    common/sched: address a violation of MISRA C Rule 8.7
    
    Rule 8.7: "Functions and objects should not be defined with external
    linkage if they are referenced in only one translation unit".
    
    This patch fixes this by adding the static specifier.
    No functional changes.
    
    Reported-by: Stewart Hildebrand stewart.hildebrand@xxxxxxx
    Signed-off-by: Victor Lira <victorm.lira@xxxxxxx>
    Acked-by: George Dunlap <george.dunlap@xxxxxxxxx>
---
 xen/common/sched/credit2.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 685929c290..b4e03e2a63 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -1476,8 +1476,8 @@ static inline void runq_remove(struct csched2_unit *svc)
     list_del_init(&svc->runq_elem);
 }
 
-void burn_credits(struct csched2_runqueue_data *rqd, struct csched2_unit *svc,
-                  s_time_t now);
+static void burn_credits(struct csched2_runqueue_data *rqd,
+                         struct csched2_unit *svc, s_time_t now);
 
 static inline void
 tickle_cpu(unsigned int cpu, struct csched2_runqueue_data *rqd)
@@ -1855,8 +1855,8 @@ static void reset_credit(int cpu, s_time_t now, struct 
csched2_unit *snext)
     /* No need to resort runqueue, as everyone's order should be the same. */
 }
 
-void burn_credits(struct csched2_runqueue_data *rqd,
-                  struct csched2_unit *svc, s_time_t now)
+static void burn_credits(struct csched2_runqueue_data *rqd,
+                         struct csched2_unit *svc, s_time_t now)
 {
     s_time_t delta;
 
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.