[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] blkif: Fix alignment description for discard request



commit e9a0101dde5f56e3dc72799798a82913546545c2
Author:     Anthony PERARD <anthony.perard@xxxxxxxxxx>
AuthorDate: Thu Sep 26 12:53:50 2024 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Thu Sep 26 14:18:03 2024 +0100

    blkif: Fix alignment description for discard request
    
    The discard feature have an other xenstore node to described the size
    of the blocks than can be discarded, "discard-granularity", which
    default to "sector-size" when absent as noted in the properties and in
    note 4. So discard request should be aligned on this value.
    
    Fixes: 221f2748e8da ("blkif: reconcile protocol specification with in-use 
implementations")
    Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
    Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 xen/include/public/io/blkif.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
index 9b00d633d3..789bab65ab 100644
--- a/xen/include/public/io/blkif.h
+++ b/xen/include/public/io/blkif.h
@@ -668,7 +668,7 @@ typedef struct blkif_request blkif_request_t;
  *
  * The 'sector_number' field is in units of 512b, despite the value of the
  * 'sector-size' xenstore node.  Note however that the offset in
- * 'sector_number' must be aligned to 'sector-size'.
+ * 'sector_number' must be aligned to 'discard-granularity'.
  */
 struct blkif_request_discard {
     uint8_t        operation;    /* BLKIF_OP_DISCARD                     */
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.