[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [qemu-xen staging-4.18] hw/riscv: virt: Fix riscv,pmu DT node path
commit e94ea3c6dbd48d70edca6de0079d5690a82ec35b Author: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> AuthorDate: Thu Jul 27 15:24:17 2023 +0100 Commit: Michael Tokarev <mjt@xxxxxxxxxx> CommitDate: Wed Sep 20 10:18:14 2023 +0300 hw/riscv: virt: Fix riscv,pmu DT node path On a dtb dumped from the virt machine, dt-validate complains: soc: pmu: {'riscv,event-to-mhpmcounters': [[1, 1, 524281], [2, 2, 524284], [65561, 65561, 524280], [65563, 65563, 524280], [65569, 65569, 524280]], 'compatible': ['riscv,pmu']} should not be valid under {'type': 'object'} from schema $id: http://devicetree.org/schemas/simple-bus.yaml# That's pretty cryptic, but running the dtb back through dtc produces something a lot more reasonable: Warning (simple_bus_reg): /soc/pmu: missing or empty reg/ranges property Moving the riscv,pmu node out of the soc bus solves the problem. Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Acked-by: Alistair Francis <alistair.francis@xxxxxxx> Reviewed-by: Daniel Henrique Barboza <dbarboza@xxxxxxxxxxxxxxxx> Message-ID: <20230727-groom-decline-2c57ce42841c@spud> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx> (cherry picked from commit 9ff31406312500053ecb5f92df01dd9ce52e635d) Signed-off-by: Michael Tokarev <mjt@xxxxxxxxxx> --- hw/riscv/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 4e3efbee16..be8f0cb26e 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -731,7 +731,7 @@ static void create_fdt_pmu(RISCVVirtState *s) MachineState *ms = MACHINE(s); RISCVCPU hart = s->soc[0].harts[0]; - pmu_name = g_strdup_printf("/soc/pmu"); + pmu_name = g_strdup_printf("/pmu"); qemu_fdt_add_subnode(ms->fdt, pmu_name); qemu_fdt_setprop_string(ms->fdt, pmu_name, "compatible", "riscv,pmu"); riscv_pmu_generate_fdt_node(ms->fdt, hart.cfg.pmu_num, pmu_name); -- generated by git-patchbot for /home/xen/git/qemu-xen.git#staging-4.18
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |