[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-xen stable-4.18] ppc/vof: Fix missed fields in VOF cleanup



commit ea25506b5d6439c76a3a6b7b55dd3f861e98eb85
Author:     Nicholas Piggin <npiggin@xxxxxxxxx>
AuthorDate: Tue Aug 8 14:19:44 2023 +1000
Commit:     Michael Tokarev <mjt@xxxxxxxxxx>
CommitDate: Sun Sep 10 19:39:41 2023 +0300

    ppc/vof: Fix missed fields in VOF cleanup
    
    Failing to reset the of_instance_last makes ihandle allocation continue
    to increase, which causes record-replay replay fail to match the
    recorded trace.
    
    Not resetting claimed_base makes VOF eventually run out of memory after
    some resets.
    
    Cc: Alexey Kardashevskiy <aik@xxxxxxxxx>
    Fixes: fc8c745d501 ("spapr: Implement Open Firmware client interface")
    Signed-off-by: Nicholas Piggin <npiggin@xxxxxxxxx>
    Reviewed-by: Alexey Kardashevskiy <aik@xxxxxxxxx>
    Signed-off-by: Cédric Le Goater <clg@xxxxxxxx>
    (cherry picked from commit 7b8589d7ce7e23f26ff53338d575a5cbd7818e28)
    Signed-off-by: Michael Tokarev <mjt@xxxxxxxxxx>
---
 hw/ppc/vof.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c
index 18c3f92317..e3b430a81f 100644
--- a/hw/ppc/vof.c
+++ b/hw/ppc/vof.c
@@ -1024,6 +1024,8 @@ void vof_cleanup(Vof *vof)
     }
     vof->claimed = NULL;
     vof->of_instances = NULL;
+    vof->of_instance_last = 0;
+    vof->claimed_base = 0;
 }
 
 void vof_build_dt(void *fdt, Vof *vof)
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#stable-4.18



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.