[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-xen stable-4.19] hw/tpm: TIS on sysbus: Remove unsupport ppi command line option



commit 36540b367eb80f1d6a646f691e6a2b75bf57ad61
Author:     Stefan Berger <stefanb@xxxxxxxxxxxxx>
AuthorDate: Thu Jul 13 13:19:55 2023 -0400
Commit:     Michael Tokarev <mjt@xxxxxxxxxx>
CommitDate: Wed Sep 20 10:18:14 2023 +0300

    hw/tpm: TIS on sysbus: Remove unsupport ppi command line option
    
    The ppi command line option for the TIS device on sysbus never worked
    and caused an immediate segfault. Remove support for it since it also
    needs support in the firmware and needs testing inside the VM.
    
    Reproducer with the ppi=on option passed:
    
    qemu-system-aarch64 \
       -machine virt,gic-version=3 \
       -m 4G  \
       -nographic -no-acpi \
       -chardev socket,id=chrtpm,path=/tmp/mytpm1/swtpm-sock \
       -tpmdev emulator,id=tpm0,chardev=chrtpm \
       -device tpm-tis-device,tpmdev=tpm0,ppi=on
    [...]
    Segmentation fault (core dumped)
    
    Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
    Reviewed-by: Eric Auger <eric.auger@xxxxxxxxxx>
    Message-id: 20230713171955.149236-1-stefanb@xxxxxxxxxxxxx
    (cherry picked from commit 4c46fe2ed492f35f411632c8b5a8442f322bc3f0)
    Signed-off-by: Michael Tokarev <mjt@xxxxxxxxxx>
---
 hw/tpm/tpm_tis_sysbus.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c
index 45e63efd63..6724b3d4f6 100644
--- a/hw/tpm/tpm_tis_sysbus.c
+++ b/hw/tpm/tpm_tis_sysbus.c
@@ -93,7 +93,6 @@ static void tpm_tis_sysbus_reset(DeviceState *dev)
 static Property tpm_tis_sysbus_properties[] = {
     DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ),
     DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver),
-    DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, false),
     DEFINE_PROP_END_OF_LIST(),
 };
 
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#stable-4.19



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.