[xen stable-4.16] stubdom: fix errors in newlib:cygmon-gmon.c

[patchbot@xxxxxxx]

commit 042aff29b5175a0eaaef389df1e05c9d0f5a6c8f
Author:     Olaf Hering <olaf@xxxxxxxxx>
AuthorDate: Wed Apr 26 10:51:56 2023 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Mon Nov 11 16:41:46 2024 +0000

    stubdom: fix errors in newlib:cygmon-gmon.c
    
    rpm post-build-checks found a few code bugs in newlib, and marks them as
    errors. Add another newlib patch and apply it during stubdom build.
    
    I: A function uses a 'return;' statement, but has actually a value
       to return, like an integer ('return 42;') or similar.
    W: xen voidreturn 
../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:117, 125, 146, 157, 330
    
    I: Program is using implicit definitions of special functions.
       these functions need to use their correct prototypes to allow
       the lightweight buffer overflow checking to work.
         - Implicit memory/string functions need #include <string.h>.
         - Implicit *printf functions need #include <stdio.h>.
         - Implicit *printf functions need #include <stdio.h>.
         - Implicit *read* functions need #include <unistd.h>.
         - Implicit *recv* functions need #include <sys/socket.h>.
    E: xen implicit-fortify-decl 
../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:119
    
    I: Program returns random data in a function
    E: xen no-return-in-nonvoid-function 
../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:362
    
    Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
    Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
    (cherry picked from commit 860fb990bd208f590b78d938ba874e867e1c2986)
---
 stubdom/Makefile                 |  1 +
 stubdom/newlib-cygmon-gmon.patch | 60 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 61 insertions(+)

diff --git a/stubdom/Makefile b/stubdom/Makefile
index 65fc9903bb..40e3f0185e 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -95,6 +95,7 @@ newlib-$(NEWLIB_VERSION): newlib-$(NEWLIB_VERSION).tar.gz
        patch -d $@ -p0 < newlib-chk.patch
        patch -d $@ -p1 < newlib-stdint-size_max-fix-from-1.17.0.patch
        patch -d $@ -p1 < newlib-disable-texinfo.patch
+       patch -d $@ -p1 < newlib-cygmon-gmon.patch
        find $@ -type f | xargs perl -i.bak \
                -pe 's/\b_(tzname|daylight|timezone)\b/$$1/g'
        touch $@
diff --git a/stubdom/newlib-cygmon-gmon.patch b/stubdom/newlib-cygmon-gmon.patch
new file mode 100644
index 0000000000..b2dfbfafe2
--- /dev/null
+++ b/stubdom/newlib-cygmon-gmon.patch
@@ -0,0 +1,60 @@
+
+I: A function uses a 'return;' statement, but has actually a value
+   to return, like an integer ('return 42;') or similar.
+W: xen voidreturn ../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:117, 
125, 146, 157, 330
+
+I: Program is using implicit definitions of special functions.
+   these functions need to use their correct prototypes to allow
+   the lightweight buffer overflow checking to work.
+     - Implicit memory/string functions need #include <string.h>.
+     - Implicit *printf functions need #include <stdio.h>.
+     - Implicit *printf functions need #include <stdio.h>.
+     - Implicit *read* functions need #include <unistd.h>.
+     - Implicit *recv* functions need #include <sys/socket.h>.
+E: xen implicit-fortify-decl 
../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:119
+
+I: Program returns random data in a function
+E: xen no-return-in-nonvoid-function 
../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:362
+
+---
+ libgloss/i386/cygmon-gmon.c |    6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+Index: newlib-1.16.0/libgloss/i386/cygmon-gmon.c
+===================================================================
+--- newlib-1.16.0.orig/libgloss/i386/cygmon-gmon.c
++++ newlib-1.16.0/libgloss/i386/cygmon-gmon.c
+@@ -61,6 +61,8 @@
+ static char sccsid[] = "@(#)gmon.c    5.3 (Berkeley) 5/22/91";
+ #endif /* not lint */
+ 
++#include <string.h>
++#include <unistd.h>
+ #define DEBUG
+ #ifdef DEBUG
+ #include <stdio.h>
+@@ -89,7 +91,7 @@ static int   s_scale;
+ 
+ extern int errno;
+ 
+-int
++void
+ monstartup(lowpc, highpc)
+      char     *lowpc;
+      char     *highpc;
+@@ -199,6 +201,7 @@ _mcleanup()
+ 
+ static char already_setup = 0;
+ 
++void
+ _mcount()
+ {
+   register char                       *selfpc;
+@@ -341,6 +344,7 @@ overflow:
+  *    profiling is what mcount checks to see if
+  *    all the data structures are ready.
+  */
++void
+ moncontrol(mode)
+     int mode;
+ {
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.16