[xen master] x86/ucode: Remove the collect_cpu_info() call from parse_blob()

[patchbot@xxxxxxx]

commit acd9bf6f89f55bca78854592c5a08a291ad752f1
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Wed Nov 6 15:56:48 2024 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Fri Nov 15 18:54:47 2024 +0000

    x86/ucode: Remove the collect_cpu_info() call from parse_blob()
    
    With the tangle of logic starting to come under control, it is now plain to
    see that parse_blob()'s side effect of re-gathering the signature/revision 
is
    pointless.
    
    The signature is invariant for the lifetime of Xen, and the revision is kept
    suitably up to date in apply_microcode().  The BSP gathers this in
    early_microcode_init(), and the APs and S3 in microcode_update_one().
    
    Therefore, there is no need for parse_blob() to discard a good copy of the
    data and re-gather it.
    
    This finally gets us down to a single call per CPU on boot / S3 resume, and 
no
    calls during late-load hypercalls.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/arch/x86/cpu/microcode/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/x86/cpu/microcode/core.c 
b/xen/arch/x86/cpu/microcode/core.c
index fd4b08b453..5897ec5403 100644
--- a/xen/arch/x86/cpu/microcode/core.c
+++ b/xen/arch/x86/cpu/microcode/core.c
@@ -189,8 +189,6 @@ static struct patch_with_flags nmi_patch =
  */
 static struct microcode_patch *parse_blob(const char *buf, size_t len)
 {
-    alternative_vcall(ucode_ops.collect_cpu_info);
-
     return alternative_call(ucode_ops.cpu_request_microcode, buf, len, true);
 }
 
--
generated by git-patchbot for /home/xen/git/xen.git#master