[xen staging] xl: properly dispose of vTPM struct instance

[patchbot@xxxxxxx]

commit 737e8cc91ba231c64a32520d6330129857aa5780
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Fri Jan 17 08:53:50 2025 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Jan 17 08:53:50 2025 +0100

    xl: properly dispose of vTPM struct instance
    
    The backend_domname field requires separate freeing; make sure to call
    libxl_device_vtpm_dispose() also on respective error paths.
    
    Coverity-ID: 1638719
    Fixes: dde22055ac3a ("libxl: add vtpm support")
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Release-Acked-By: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
---
 tools/xl/xl_vtpm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/xl/xl_vtpm.c b/tools/xl/xl_vtpm.c
index 0ba5041609..ef3e11f1ac 100644
--- a/tools/xl/xl_vtpm.c
+++ b/tools/xl/xl_vtpm.c
@@ -44,12 +44,14 @@ int main_vtpmattach(int argc, char **argv)
         if (MATCH_OPTION("uuid", *argv, oparg)) {
             if(libxl_uuid_from_string(&(vtpm.uuid), oparg)) {
                 fprintf(stderr, "Invalid uuid specified (%s)\n", oparg);
+                libxl_device_vtpm_dispose(&vtpm);
                 return 1;
             }
         } else if (MATCH_OPTION("backend", *argv, oparg)) {
             replace_string(&vtpm.backend_domname, oparg);
         } else {
             fprintf(stderr, "unrecognized argument `%s'\n", *argv);
+            libxl_device_vtpm_dispose(&vtpm);
             return 1;
         }
     }
@@ -65,6 +67,7 @@ int main_vtpmattach(int argc, char **argv)
 
     if (libxl_device_vtpm_add(ctx, domid, &vtpm, 0)) {
         fprintf(stderr, "libxl_device_vtpm_add failed.\n");
+        libxl_device_vtpm_dispose(&vtpm);
         return 1;
     }
     libxl_device_vtpm_dispose(&vtpm);
--
generated by git-patchbot for /home/xen/git/xen.git#staging