[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] x86/emul: Make condition coverage warning non-fatal



commit 3718af7ed485aa61fd7f3fc53559349ed6fd1f60
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Fri Sep 12 10:03:01 2025 +0100
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Sat Sep 13 01:02:28 2025 +0100

    x86/emul: Make condition coverage warning non-fatal
    
    Randconfig with GCC-14 (Debian Trixie) found:
    
      In file included from arch/x86/x86_emulate/x86_emulate.c:11,
                       from arch/x86/x86_emulate.c:27:
      arch/x86/x86_emulate/x86_emulate.c: In function 'x86_emulate':
      arch/x86/x86_emulate/private.h:482:8: error: Too many conditions (found 
826); giving up coverage [-Werror=coverage-too-many-conditions]
        482 | ({  if ( (p) ) {                                                  
        \
            |        ^
      arch/x86/x86_emulate/x86_emulate.c:1283:5: note: in expansion of macro 
'generate_exception_if'
       1283 |     generate_exception_if((mode_vif() &&
            |     ^~~~~~~~~~~~~~~~~~~~~
    
    which is a consequence of having a new enough compiler to allow
    CONFIG_CONDITION_COVERAGE in to the mix.
    
    In the short term make warning non-fatal, but this will need fixing
    properly in due course.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
 xen/arch/x86/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
index d7aed7d92c..407571c510 100644
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -98,6 +98,9 @@ $(obj)/usercopy.o: CFLAGS-y += -iquote .
 ifneq ($(CONFIG_HVM),y)
 $(obj)/x86_emulate.o: CFLAGS-y += -Wno-unused-label
 endif
+ifeq ($(CONFIG_CONDITION_COVERAGE),y)
+$(obj)/x86_emulate.o: CFLAGS-y += -Wno-error=coverage-too-many-conditions
+endif
 
 efi-y := $(shell if [ ! -r $(objtree)/include/xen/compile.h -o \
                       -O $(objtree)/include/xen/compile.h ]; then \
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.