[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen stable-4.20] x86emul/test: correct compiler checking and avoid it when merely cleaning



commit 840b0294dfc5bdafb2139315d65fe06b38fe6296
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Tue Nov 25 09:37:38 2025 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Nov 25 09:37:38 2025 +0100

    x86emul/test: correct compiler checking and avoid it when merely cleaning
    
    The error messages that the compiler may emit can be confusing.
    
    The check was also the wrong way round in case multiple make targets are
    specified: We want to do the check whenever targets other than the running
    and cleaning ones are specified.
    
    Fixes: 05f4cc219235 ("x86emul: suppress default test harness build with 
incapable compiler")
    Fixes: d5997399b7ad ("x86emul: suppress "not built" warning for test 
harness'es run targets")
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    master commit: c482d1f59fc723d5b0aca3b288ca2f6007cd00a4
    master date: 2025-11-24 11:28:47 +0100
---
 tools/tests/x86_emulator/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tests/x86_emulator/Makefile 
b/tools/tests/x86_emulator/Makefile
index 2228a8591a..d632c8c222 100644
--- a/tools/tests/x86_emulator/Makefile
+++ b/tools/tests/x86_emulator/Makefile
@@ -98,7 +98,7 @@ avx512bw-opmask-vecs := 4 8
 # partially even with older compilers.
 TARGET-y := $(TARGET)
 
-ifeq ($(filter run%,$(MAKECMDGOALS)),)
+ifneq ($(filter-out run% clean% distclean,$(MAKECMDGOALS)),)
 
 define isa-check-cc
 TARGET-$(shell echo 'int i;' | $(CC) -x c -c -o /dev/null -m$(1) - || echo y) 
:=
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.20



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.