|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] Arm/GIC: add noreturn in a few more places
commit 6852334f84166245b861a9b995ab6c9b7b44f503
Author: Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Tue Sep 1 10:00:01 2026 +0200
Commit: Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Sep 1 10:00:01 2026 +0200
Arm/GIC: add noreturn in a few more places
LPI related functions having just BUG() in them are disliked by Misra /
Eclair, as long as they don't also have a noreturn attribute.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
xen/arch/arm/gic-v2.c | 2 +-
xen/arch/arm/include/asm/gic_v3_its.h | 2 +-
xen/arch/arm/vgic-v2.c | 7 ++++---
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index 43a379fdda..d05c574d88 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -1315,7 +1315,7 @@ static int __init gicv2_init(void)
return 0;
}
-static void gicv2_do_LPI(unsigned int lpi)
+static void noreturn gicv2_do_LPI(unsigned int lpi)
{
/* No LPIs in a GICv2 */
BUG();
diff --git a/xen/arch/arm/include/asm/gic_v3_its.h
b/xen/arch/arm/include/asm/gic_v3_its.h
index fc5a84892c..02c083f210 100644
--- a/xen/arch/arm/include/asm/gic_v3_its.h
+++ b/xen/arch/arm/include/asm/gic_v3_its.h
@@ -229,7 +229,7 @@ static inline unsigned int vgic_v3_its_count(const struct
domain *d)
return 0;
}
-static inline void gicv3_do_LPI(unsigned int lpi)
+static inline void noreturn gicv3_do_LPI(unsigned int lpi)
{
/* We don't enable LPIs without an ITS. */
BUG();
diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index 3fa8cdeeab..6328ce6f7e 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -718,14 +718,15 @@ static void vgic_v2_domain_free(struct domain *d)
/* Nothing to be cleanup for this driver */
}
-static struct pending_irq *vgic_v2_lpi_to_pending(struct domain *d,
- unsigned int vlpi)
+static struct pending_irq *noreturn vgic_v2_lpi_to_pending(struct domain *d,
+ unsigned int vlpi)
{
/* Dummy function, no LPIs on a VGICv2. */
BUG();
}
-static int vgic_v2_lpi_get_priority(struct domain *d, unsigned int vlpi)
+static int noreturn vgic_v2_lpi_get_priority(struct domain *d,
+ unsigned int vlpi)
{
/* Dummy function, no LPIs on a VGICv2. */
BUG();
--
generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |