|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] x86/PCI: use pci_sbdf_t also for pci_dev_base()
commit c3b570e1b5fca14adc47070f5a989588ae1120ce
Author: Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Thu Sep 10 09:00:55 2026 +0200
Commit: Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Sep 10 09:00:55 2026 +0200
x86/PCI: use pci_sbdf_t also for pci_dev_base()
No need to pass three arguments when both callers already hold SBDF in
their hands.
No functional change.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger@xxxxxxxxxxxxxx>
Reviewed-by: Teddy Astie <teddy.astie@xxxxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
xen/arch/x86/x86_64/mmconfig_64.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/xen/arch/x86/x86_64/mmconfig_64.c
b/xen/arch/x86/x86_64/mmconfig_64.c
index 6477bf8b44..05b9abee5a 100644
--- a/xen/arch/x86/x86_64/mmconfig_64.c
+++ b/xen/arch/x86/x86_64/mmconfig_64.c
@@ -45,14 +45,15 @@ static char __iomem *get_virt(unsigned int seg, unsigned
int *bus)
return NULL;
}
-static char __iomem *pci_dev_base(unsigned int seg, unsigned int bus, unsigned
int devfn)
+static char __iomem *pci_dev_base(pci_sbdf_t sbdf)
{
- char __iomem *addr;
+ unsigned int bus = sbdf.bus;
+ char __iomem *addr = get_virt(sbdf.seg, &bus);
- addr = get_virt(seg, &bus);
if (!addr)
return NULL;
- return addr + ((bus << 20) | (devfn << 12));
+
+ return addr + ((bus << 20) | (sbdf.devfn << 12));
}
int pci_mmcfg_read(
@@ -66,7 +67,7 @@ err: *value = -1;
return -EINVAL;
}
- addr = pci_dev_base(sbdf.seg, sbdf.bus, sbdf.devfn);
+ addr = pci_dev_base(sbdf);
if (!addr)
goto err;
@@ -94,7 +95,7 @@ int pci_mmcfg_write(
if (unlikely(reg + len > PCI_CFG_SPACE_EXP_SIZE))
return -EINVAL;
- addr = pci_dev_base(sbdf.seg, sbdf.bus, sbdf.devfn);
+ addr = pci_dev_base(sbdf);
if (!addr)
return -EINVAL;
--
generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |