# HG changeset patch # User Juergen Gross # Date 1297086851 -3600 # Node ID ab8e5220b68e9925232c8ba03868a81a15bcede6 # Parent e44f3ab80d1428020b51abd9be4fa5d71b6c32bc Correct cpupool diag printing Some of the cpupool_dprintk() calls are using undefined or uninitialized variables. Correct the argument lists to be able to define cpupool_printk as printk. Signed-off-by: juergen.gross@xxxxxxxxxxxxxx diff -r e44f3ab80d14 -r ab8e5220b68e xen/common/cpupool.c --- a/xen/common/cpupool.c Mon Feb 07 12:13:24 2011 +0000 +++ b/xen/common/cpupool.c Mon Feb 07 14:54:11 2011 +0100 @@ -232,8 +232,8 @@ static long cpupool_unassign_cpu_helper( int cpu = cpupool_moving_cpu; long ret; - cpupool_dprintk("cpupool_unassign_cpu(pool=%d,cpu=%d) ret %ld\n", - cpupool_id, cpu, ret); + cpupool_dprintk("cpupool_unassign_cpu(pool=%d,cpu=%d)\n", + cpupool_cpu_moving->cpupool_id, cpu); spin_lock(&cpupool_lock); ret = cpu_disable_scheduler(cpu); @@ -254,6 +254,7 @@ static long cpupool_unassign_cpu_helper( out: spin_unlock(&cpupool_lock); + cpupool_dprintk("cpupool_unassign_cpu ret=%ld\n", ret); return ret; } @@ -331,7 +332,7 @@ out: out: spin_unlock(&cpupool_lock); cpupool_dprintk("cpupool_unassign_cpu(pool=%d,cpu=%d) ret %d\n", - cpupool_id, cpu, ret); + c->cpupool_id, cpu, ret); return ret; } @@ -345,7 +346,7 @@ int cpupool_add_domain(struct domain *d, { struct cpupool *c; int rc = 1; - int n_dom; + int n_dom = 0; if ( poolid == CPUPOOLID_NONE ) return 0;