x86/shadow: add a clarifying assertion ... documenting that we don't have to worry about merging guest provided flags with the ones we want to enforce ourselves. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -592,6 +592,8 @@ _sh_propagate(struct vcpu *v, { unsigned int type; + ASSERT(!(sflags & (_PAGE_PAT | _PAGE_PCD | _PAGE_PWT))); + /* compute the PAT index for shadow page entry when VT-d is enabled * and device assigned. * 1) direct MMIO: compute the PAT index with gMTRR=UC and gPAT.