RE: [Xen-ia64-devel] lsapic deliver external IRQ

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

Magenheimer, Dan (HP Labs Fort Collins) wrote:
> 
> I see... if you are suggesting that the call to
> check_pending_interrupts is expensive and returns "no
> interrupt" almost all the time, I fully agree.
> This call could/should be changed to just check
> the domain's pending_interruption flag.  But I seem
> to recall that I tried that and the test failed (probably
> the machine froze) so I fell back to the more conservative
> call that worked.  Perhaps it is time to try it again.
> 
> Dan
Thanks, we got same point.

BTW, set pending_interruption flag has potential issue as vpsr.i and
vtpr may change time by time. My proposal will eliminate
deliver_pending_interrupt function so that HV return to guest will not
need to check any pending IRQs. Instead when guest vIRR get changed or
vpsr.i and vtpr get changed, I inject/reflect interruption immediately
if it meets the interrupt deliver condition. (I.e change guest context
for external IRQ immediately).
I will provide this patch together in the merge if you like to see it.
Eddie

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel