[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-ia64-devel] MAJOR cleanup in patched-from-linux code


  • To: <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
  • Date: Mon, 2 May 2005 13:31:36 -0700
  • Delivery-date: Mon, 02 May 2005 20:31:44 +0000
  • List-id: DIscussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
  • Thread-index: AcVPVfAB+miZH566RzKIcJQIiAlWwQ==
  • Thread-topic: MAJOR cleanup in patched-from-linux code

I just checked in to xen-ia64.bkbits.net://xeno-unstable-ia64.bk
a major cleanup to the linux patch files.  Many of the patches
were cluttered with unnecessary additions and some of the files
appeared to be better off checked in directly rather than on top
of the linux source.

(Note that bkbits.net is having some problems in its admin
interface, so it may take a day or two to push these changes
to xen.bkbits.net.)

Here's the results:

BEFORE:
38 patch files
1027 lines added
160 lines subtracted 

AFTER:
24 patch files
348 lines added
2 lines subtracted

Of the 348 lines added, 151 are real code and the rest
are conditional compile directives (#ifdef/#else/#endif etc).
All changes are clearly marked with ifdef's, with the
exception of two lines which are in the middle of a huge
assembly macro.

Why not get rid of these entirely and just check in the
Linux sources?  Because mkbuildtree links in almost 32000
lines of Linux/ia64 source files and only slightly more
than 1% change is required to utilize these in Xen/ia64.
That's leverage!


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.