[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-ia64-devel] FW: IA-64 serial driver


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
  • Date: Tue, 31 May 2005 06:27:46 -0700
  • Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 31 May 2005 13:27:24 +0000
  • List-id: DIscussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
  • Thread-index: AcVl4rElcfXva4y0Ss6pZrnF73x0VwAAMtYw
  • Thread-topic: [Xen-ia64-devel] FW: IA-64 serial driver

> > How about using "xenconsole=" and "xencom2=" to differentiate
> > from the dom0 xenlinux command line parameters?  Then there
> > won't be an ordering constraint (which as you point out could
> > lead to a common problem).
> 
> The parameter names and the command-line parser are not 
> arch-specific, 
> so this would be quite hard to do.

I have to admit I am not familiar with the driver code, but
isn't it simply adding another string_param line (as an
alias for console= not a replacement) and an additional
strncmp test in init_console?

> An alternative might be to 
> specify a 
> shared command line in the form:
>   "xen(<xen params here>) dom0(<dom0 params here>)"
> Then, in your ia64 start-of-day code you pull the shared command line 
> out into two separate strings: the first you pass off to 
> cmdline_parse() and the second you pass off to domain0.
> 
> I think this is a cleaner format and will have a cleaner 
> implementation.

Yes, I suppose you are right, though I shudder to think about
all the "my configuration doesn't work anymore" questions.
I guess those will happen regardless of how we do it.

Perhaps we could/should use
the "--" separator like grep (and getopts?) uses, e.g.
console=xxx com2=yyy -- console=zzz com2=www nomca
 ^ xen arguments ^       ^ dom0 arguments^

What do you think Kevin?  Want to spin a patch for this?

Thanks,
Dan

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.