Re: [Xen-ia64-devel] RE: in_tpa is not SMP-safe

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Mercredi 08 Mars 2006 18:38, Magenheimer, Dan (HP Labs Fort Collins) a 
écrit :
> I was hoping Kevin would respond to this as my memory
> on it is dim.  There was a rare but significant problem
> that this code was fixing and we went through several
> attempts to fix it.  I don't think we ever understood
> exactly why this code was necessary because we (both
> Kevin and I) thought a different code sequence should
> work, but it didn't.
>
> So, yes, make the change to make it SMP-safe (I prefer
> the parameter), but be careful about changing the
> "in_tpa" semantics without running a very thorough
> test suite.
Ok.

Also, vcpu_translate look in itr_regions even for data_access.  There is a 
comment about that:
// FIXME?: check itr's for data accesses too, else bad things happen?
I suppose this is required to read instructions from Xen.  Are there any other 
uses ?  Is it too dangerous to try to fix that ?

Tristan.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel