[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-ia64-devel]Question about priv_ptc_e



>From: Magenheimer, Dan (HP Labs Fort Collins) 
>Sent: 2006年3月11日 1:35
>It would be OK to clean this up.  It may actually be
>causing a bug!  But I would like to preserve the code
>rather than remove it as it is possible that it may
>be used again.  It would be OK though to tie it to a
>global variable / command line option that defaults
>off.  For example:
>
> // NOTE: ptc_e with source gr > 63 is emulated as a fc r(y-64)
>-      if (src > 63) return(vcpu_fc(vcpu,vcpu_get_gr(vcpu,src - 64)));
>+      if (privified && src > 63)
>+              return(vcpu_fc(vcpu,vcpu_get_gr(vcpu,src - 64)));
>       return vcpu_ptc_e(vcpu,vcpu_get_gr(vcpu,src));
>
>There are several of these that need to be changed,
>so let's change all of them the same way at the same time.

It is still being used.
At least, Dom0 uses pte.e to emulate fc.
GLOBAL_ENTRY(xen_fc)
    261     movl r8=running_on_xen;;
    262     ld4 r8=[r8];;
    263     cmp.eq p7,p0=r8,r0;;
    264 (p7)    fc r32;;
    265 (p7)    br.ret.sptk.many rp
    266     ;;
    267     ptc.e r96       // this is a "privified" fc r32
    268     ;;
    269     br.ret.sptk.many rp
    270 END(xen_fc)

Thanks,
Anthony

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.