[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-ia64-devel] [PATCH] [RFC] [TAKE2] P2M/VP (incomplete) patches


  • To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Thu, 16 Mar 2006 11:40:36 +0800
  • Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 16 Mar 2006 03:42:02 +0000
  • List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
  • Thread-index: AcZIo7HCcHoTPl7nTcOby20wiRHzRgAAEMOA
  • Thread-topic: [Xen-ia64-devel] [PATCH] [RFC] [TAKE2] P2M/VP (incomplete) patches

>From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx]
>Sent: 2006年3月16日 10:43
>
>I haven't cleaned up grant table api yet.
>I'm sure some clean up is necessary. This is the reason why XXX is
>there.
>I'll work on it after getting vnif to work.

OK.

>
>
>> BTW, what's the intent of alloc_vm_area? Seems no one calls it. Also a
>> typo there:
>> struct vm_struct* area;
>> ...
>> area = kmalloc(sizeof(area), GFP_KERNEL); which only gives you 8
>> bytes. :-)
>
>Oops thanks.
>alloc_vm_area() is called by blkback, blktap, netback, tpmback, xenbus
>to allocate virtual address area of xen I/O ring.
>Allocating virtual address area which doesn't have corresponding
>pseudo physical page is xen/x86-ism.
>Some clean up is also needed.

You're right. I only looked context of your patch sets.

Thanks,
Kevin

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.