RE: [Xen-ia64-devel] PATCH: cache flush

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Tristan Gingold [mailto:Tristan.Gingold@xxxxxxxx]
>Sent: 2006年4月4日 15:47
>>
>> One small question. Why do you check upon '4' in sal emulation?
>>
>> +            /*  The best we can do is to flush with fc all the domain.
>*/
>> +            domain_cache_flush (current->domain, in1 == 4 ? 1 : 0);
>> +            status = 0;
>>
>> Is it the parameter pass convention? From the SAL spec, 1 for
>instruction
>> cache, 2 for data cache and 3 for both. Seems I missed something
>here.
>According to my spec, 4 is for synchronizing I and D cache.
>Therefore I use fc for 1,2,3 and fc.i for 4.

Oops, I looked at an old version. :-(

>
>> You may also want to add similar emulation for PAL_CACHE_FLUSH,
>> though it won't be hit especially after applying Alex's patch. But it never
>> hurts to add for safety. :-)
>I will add this to my todo list.
>
>BTW, my current implementation makes CACHE_FLUSH uninterruptible.
>Should we
>improve that ?

Seems so. But this may not be urgent.

Thanks,
Kevin

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel