Re: [Xen-ia64-devel] [PATCH] SetVirtualAddressMap emulation support

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Lundi 24 Avril 2006 17:11, Tristan Gingold a écrit :
> Le Lundi 24 Avril 2006 16:45, Masaki Kanno a écrit :
> > Hi,
> >
> > I'm working on FPSWA support, and I'm thinking that I will offer
> > a dummy fpswa function to dom0/domU. Therefore I think that Xen
> > has to support the SetVirtualAddressMap() emulation of EFI.
> > This patch supports the SetVirtualAddressMap() emulation in Xen.
> >
> > I confirmed that following EFI Runtime emulation worked in a
> > virtual address.
> >  - GetTime() in dom0
> >  - GetTime() in domU
>
> Hi,
>
> Three points:
> * you should write a generic function to do
> vcpu_tpa+__va(translate_domain_mpaddr).
>
> * I prefer '|'
> MAKE_MD(EFI_PAL_CODE,EFI_MEMORY_WB|EFI_MEMORY_RUNTIME,HYPERCALL_START,HYPER
>CALL_END,1); instead of '+'
> MAKE_MD(EFI_PAL_CODE,EFI_MEMORY_WB+EFI_MEMORY_RUNTIME,HYPERCALL_START,HYPER
>CALL_END,1);
>
> * You don't handle vcpu_tpa failure.  This may never happen for GetTime,
> but fore sure may happen for other calls. This may be not trivial.
One possible solution is to put the tpa instructions inside the pal/sal/efi 
stubs.  This can make stubs bigger, but creates flexibility.

Tristan.



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel