Re: [Xen-ia64-devel] [Patch] Reseve memory of domain0 (fix dom0 boot panic)

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi,

>> >Why does the region need reservation?
>> >dom0/initrd images are copied by construct_dom0().
>> >The dom0/initrd regions must not be used before contruct_dom0(),
>> >but they can be used after construct_dom0().
>> Yes, dom0/inird images are copied by construct_dom0().
>> But the region is clean up by init_virtual_frametable() 
>> before construct_dom0 is called.
>> So the region need reservation.
>
>You only explained the region shouldn't have been used until the copy
>by construct_dom0().
>Why do you waste memory of the regions?
>The reservation can be accepted as a temporal work around.
>But it isn't right.
You are right. I want to free the reserved regions after construct_dom0().
But now, please leave the reserved code since the waste memory is small.
I'll make free_initrd_mem() like a linux and fix it.
What do you think about it?

>> >The above change is wrong. Please backout or fix somehow.
>> >With P=M model it works but it isn't right. It breaks the P2M/VP patches.
>> >Please see construct_dom0().
>> I attach a patch which fix the above bug.
>> Am I correct?
>
>It looks correct with respect to bp->initrd_start.
Thank you, another is cleanup. :->

Best Regards,

Akio Takebe


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel