RE: [Xen-ia64-devel][PATCH] fixed a bug which causes Oops

["Xu, Anthony" <anthony.xu@xxxxxxxxx>]

Resend

Thanks,
-Anthony 

>-----Original Message-----
>From: Alex Williamson [mailto:alex.williamson@xxxxxx]
>Sent: 2006?6?1? 0:10
>To: Xu, Anthony
>Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-ia64-devel][PATCH] fixed a bug which causes Oops
>
>On Wed, 2006-05-31 at 12:13 +0800, Xu, Anthony wrote:
>> @@ -171,8 +174,11 @@ void vtm_set_itm(VCPU *vcpu, uint64_t va
>>      clear_bit(ITV_VECTOR(vitv), &VCPU(vcpu, irr[0]));
>>      VCPU(vcpu,itm)=val;
>>      cur_itc =now_itc(vtm);
>> +    diff_itc = val-cur_itc;
>> +    if(diff_itc < 0)
>> +        diff_itc = 0;
>>      if(val >  vtm->last_itc){
>> -        expires = NOW() + cycle_to_ns(val-cur_itc) + TIMER_SLOP;
>> +        expires = NOW() + cycle_to_ns(diff_itc) + TIMER_SLOP;
>
>Hi Anthony,
>
>  I think this should probably use time_after(), something like:
>
>    if (time_after(val, cur_itc))
>        val = cur_itc;
>
>Thanks,
>
>       Alex
>
>--
>Alex Williamson                             HP Open Source & Linux Org.

Attachment: new_vti_oops_fix.patch
Description: new_vti_oops_fix.patch

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel