[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-ia64-devel] [PATCH] increase buffer size in panic_domain()



On Tue, 2006-07-25 at 13:02 +0900, Isaku Yamahata wrote:
> --- a/xen/arch/ia64/xen/xenmisc.c       Mon Jul 24 21:25:30 2006 +0900
> +++ b/xen/arch/ia64/xen/xenmisc.c       Mon Jul 24 21:25:30 2006 +0900
> @@ -172,7 +172,7 @@ void panic_domain(struct pt_regs *regs, 
>  void panic_domain(struct pt_regs *regs, const char *fmt, ...)
>  {
>         va_list args;
> -       char buf[128];
> +       static char buf[1024]; 

Hi Isaku,

   The static here will cause problems if panic_domain() is called
concurrently from multiple CPUs.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.