Re: [Xen-ia64-devel] [PATCH] pal_halt_light emulate for domU TAKE3

[Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>]

The difference from TAKE2

Status

I tested 2xDomU Linux Kernel Compile Test on 4xpCPU w/ credit scheduler.
It passes more than 16h testing.(21h in real) 

Changes

1)migrate_timer for hlt_timer_fn is added for context_switch
  This makes correct pCPU work for timer.

2)To avoid soft lockup message(10sec timer stop) at Dom0/U,
  I add the condition for checking in vcpu_get_next_timer_ns.
  domain_itm > ia64_get_itc
  If above condition is not satisfied 
  Just set the timer interval itm_delta from NOW().

3)Remove vcpu_pend_timer from hlt_timer_fn.
  It previously makes the state that vcpu is running but timer(VIRQ_ITC) is 
stopped.

(References)
Yamahata's for VTI migrate timer.
http://lists.xensource.com/archives/html/xen-ia64-devel/2006-07/msg00375.html
stop_timer
http://lists.xensource.com/archives/html/xen-ia64-devel/2006-07/msg00171.html


Signed-off-by: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>

Thanks
Atsushi SAKAI



>Hi, Isaku 
>
> Logically, it could be removed.
>But I am not tested under your suggest configuration.
>I will test on your configuration.
>
>Thanks
>Atsushi SAKAI
>
>
>>On Tue, Aug 22, 2006 at 05:28:54PM +0900, Atsushi SAKAI wrote:
>>
>>> So this patch does not need to add vcpu_pend_timer fixes.
>>
>>O.K.
>>So the modification of vcpu_pend_timer() is unnecessary for the patch.
>>
>>
>>> But this should be fixed in sometime.
>>
>>Does you mean that the following hank is still needed?
>>Why? What issue does the change resolve?
>>
>>@@ -1167,8 +1167,8 @@ void vcpu_pend_timer(VCPU *vcpu)
>>                 * handler has not been registered. Don't fire in such case.
>>                 */
>>                if (vcpu->virq_to_evtchn[VIRQ_ITC]) {
>>+                       PSCBX(vcpu, domain_itm_last) = PSCBX(vcpu, 
>>domain_itm);
>>                        send_guest_vcpu_virq(vcpu, VIRQ_ITC);
>>-                       PSCBX(vcpu, domain_itm_last) = PSCBX(vcpu, 
>>domain_itm);
>>                }
>>        } else
>>                vcpu_pend_interrupt(vcpu, itv);
>>-- 
>>yamahata
>>
>
>
>
>
>
>
>
>_______________________________________________
>Xen-ia64-devel mailing list
>Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-ia64-devel
>

Attachment: pal_halt_light_emul_domu_take3b.patch
Description: Binary data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel