Re: [Xen-ia64-devel] PV-on-HVM driver for IPF

[Alex Williamson <alex.williamson@xxxxxx>]

On Sat, 2006-08-26 at 14:45 +0900, åè åä wrote:
>  
> -    /* Copy existing grant table shared into new page */
> +    /* Copy existing grant table new page */
>      if (o_grant_shared) {
>          memcpy((void *)d->grant_table->shared,
>                 (void *)o_grant_shared, PAGE_SIZE * nr_frames);

   The existing comment seems to make more sense here.  Should it be
"Copy existing grant table into new page"?

   The patch below causes the kernel build to fail when CONFIG_XEN is
not set.  Why remove the CONFIG_XEN statement?  Thanks,

        Alex

> diff -r 153ba50864b7 -r 9647400b5041
> linux-2.6-xen-sparse/include/asm-ia64/hypercall.h
> --- a/linux-2.6-xen-sparse/include/asm-ia64/hypercall.h Sat Aug 26
> 13:33:16 2006 +0900
> +++ b/linux-2.6-xen-sparse/include/asm-ia64/hypercall.h Sat Aug 26
> 13:37:41 2006 +0900
> @@ -315,7 +315,9 @@ static inline void exit_idle(void) {}
>  })
>  
>  #include <linux/err.h>
> +#ifdef CONFIG_XEN
>  #include <asm/xen/privop.h>
> +#endif /* CONFIG_XEN */
>  
>  static inline unsigned long
>  __HYPERVISOR_ioremap(unsigned long ioaddr, unsigned long size)
> diff -r 153ba50864b7 -r 9647400b5041
> linux-2.6-xen-sparse/include/asm-ia64/hypervisor.h
> --- a/linux-2.6-xen-sparse/include/asm-ia64/hypervisor.h        Sat
> Aug 26 13:33:16 2006 +0900
> +++ b/linux-2.6-xen-sparse/include/asm-ia64/hypervisor.h        Sat
> Aug 26 13:37:41 2006 +0900
> @@ -33,15 +33,9 @@
>  #ifndef __HYPERVISOR_H__
>  #define __HYPERVISOR_H__
>  
> -#ifndef CONFIG_XEN
> -#define is_running_on_xen()                    (0)
> -#define HYPERVISOR_ioremap(offset, size)       (offset)
> -#else
>  extern int running_on_xen;
>  #define is_running_on_xen()                    (running_on_xen)
> -#endif
>  
> -#ifdef CONFIG_XEN 
-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel