RE: [Xen-ia64-devel][PATCH]fix vti inital broken after merge

["Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>]

Hi Alex:
        With this patch, SMP HVM only can boot as UP. Due to add_vcpus_hob() 
has been removed from build_hob(). Since parameter 'vcpus' not available in 
setup_guest(). We prefer to use index 'PAE' to save vcpus to xen in python code 
and get it back in setup_guest(). Codes probably like below:

In arch-ia64.h:
+/* HVM_PARAM_PAE_ENABLED not used in IA64, so we used this param to save vcpu
+  number */
+#define HVM_PARAM_VCPUS HVM_PARAM_PAE_ENABLE

In xc.c:
+#if defined(__ia64__)
+    xc_set_hvm_param(self->xc_handle, dom, HVM_PARAM_VCPUS, vcpus);
+#endif

In xc_ia64_hvm_build.c
+       xc_get_hvm_param(xc_handle, dom, HVM_PARAM_VCPUS, &vcpus)



Good good study,day day up ! ^_^
-Wing(zhang xin)
 
OTC,Intel Corporation

>-----Original Message-----
>From: Alex Williamson [mailto:alex.williamson@xxxxxx]
>Sent: 2006年12月5日 5:19
>To: Xu, Anthony
>Cc: Zhang, Xing Z; xen-ia64-devel
>Subject: RE: [Xen-ia64-devel][PATCH]fix vti inital broken after merge
>
>On Mon, 2006-12-04 at 09:54 +0800, Xu, Anthony wrote:
>> Alex Williamson write on 2006年12月2日 1:44:
>> >
>> >    I think it would be cleaner just to make the ia64 specific
>> > xc_set_hvm_param() ignore HVM_PARAM_PAE_ENABLED (or have the xen side
>> > of the hypercall ignore it).
>>
>> Alex,
>>
>> For HVM_INFO and HVM_PARAM_PAE_ENABLED, I think they are IA32-spicific,
>> and should not be put in common path.
>
>Hi Anthony,
>
>   Does that mean SMP HVM guests work with this patch?  I was wondering
>if HVM_INFO is how x86 is setting up the number of vCPUs.  I removed the
>code in tools/libxc/ia64/xc_ia64_hvm_build.c that appeared to handle
>this, so thought we might need to migrate to something like HVM_INFO to
>do that now.  PAE is x86 specific of course, but it's part of the
>generic HVM params.  It won't hurt anything to set the parameter on
>ia64, it just won't do anything.  Maybe after 3.0.4 it would be
>worthwhile to create an interface for setting arch-specific parameters.
>Thanks,
>
>       Alex
>
>--
>Alex Williamson                             HP Open Source & Linux Org.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel