Re: [Xen-ia64-devel] [Patch] Modify for compiling PV-on-HVM and following callback_via

[Alex Williamson <alex.williamson@xxxxxx>]

On Tue, 2007-02-06 at 12:25 +0900, Doi.Tsunehisa@xxxxxxxxxxxxxx wrote:
> Hi Alex,
> 
> You (alex.williamson) said:
> >> --- a/xen/include/public/arch-ia64.h    Mon Feb 05 13:19:10 2007 +0900
> >> +++ b/xen/include/public/arch-ia64.h    Mon Feb 05 13:20:48 2007 +0900
> >> @@ -64,9 +64,11 @@ DEFINE_XEN_GUEST_HANDLE(xen_pfn_t);
> >>  #define VIRQ_MCA_CMC    VIRQ_ARCH_1 /* MCA cmc interrupt */
> >>  #define VIRQ_MCA_CPE    VIRQ_ARCH_2 /* MCA cpe interrupt */
> >>  
> >> +#if 0
> >>  /* Arch specific callback irq definition */
> >>  /* using Requester-ID(RID) as callback irq */
> >>  #define IA64_CALLBACK_IRQ_RID        (1 << 31)
> >> +#endif
> > 
> >    Is this ever going to be defined?  If not, I'd rather see it deleted
> > along with the associated code.  Thanks,
> 
>   I'm waving to decide it.
> 
>   I think that we should delete the definition for the future, but
> we'll have to keep it for backward compatibility.
> 
>   This spec is not included in any release version, thus we should
> select to delete it, I think.
> 
>   What do you think about this ?

   IMHO, if it's #if 0'd out, it's not really adding to backwards
compatibility anyway.  This wasn't in 3.0.4, so I think we should
probably drop it.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel