Re: [Xen-ia64-devel] [PATCH] free initmem and add __init and __initdata.

[Alex Williamson <alex.williamson@xxxxxx>]

On Tue, 2007-05-22 at 12:27 +0900, Isaku Yamahata wrote:
> On Mon, May 21, 2007 at 04:46:13PM -0600, Alex Williamson wrote:
> 
> > I tried removing all the __inits and __initdatas this patch added, but
> > it still happens, so I'd guess we need something that upstream marked as
> > init.  Thanks,
> 
> Thank you for testing.
> I attached the updated patch. The diff from the previous one is as follows.
> 
> diff -r b2b0289b0575 -r be593e2059de xen/arch/ia64/xen/xensetup.c
> --- a/xen/arch/ia64/xen/xensetup.c      Mon May 21 16:48:44 2007 +0900
> +++ b/xen/arch/ia64/xen/xensetup.c      Tue May 22 12:07:48 2007 +0900
> @@ -242,7 +242,7 @@ md_overlaps(efi_memory_desc_t *md, unsig
>  
>  #define MD_SIZE(md) (md->num_pages << EFI_PAGE_SHIFT)
>  
> -static void init_done(void)
> +static void noinline init_done(void)
>  {
>      extern char __init_begin[], __init_end[];
>      init_xenheap_pages(__pa(__init_begin), __pa(__init_end));
> 

Hi Isaku,

   Good thought, but I still hit the same problem.  Note that dom0 boots
fine, but hits the BUG trying to boot a domU.  I am running a newer gcc:

gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

I'll put the __init/__initdata declarations in, but leave the actual
freeing disabled until we can track this down.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel