Re: [Xen-ia64-devel] Re: [patch] emulate more SN2 SAL calls

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-05-23 at 08:46 +0200, Jes Sorensen wrote:
> Alex Williamson wrote:
> > On Tue, 2007-05-22 at 15:09 +0200, Jes Sorensen wrote:
> >> Hi,
> >>
> >> We need some more SAL calls emulated on SN2.
> > 
> >    Are we getting to a point that we should should expand the machine
> > vectors when running on Xen to include a platform specific SAL emulator?
> > For example, ia64_mv.oem_sal_emulator?  Thanks,
> 
> Hi Alex,
> 
> I'd prefer to just keep them in the global file and it's slow path code
> so it's not a big issue. Kinda like ioctls. In addition, we may one day
> want to emulate an Altix on a ZX1 or vice versa :-)

  Ok, I can live with it for now.  Isn't there also a chance that
vendors could have overlapping OEM SAL calls, or did SGI get assigned
0x020000XX?  In practice, I don't think this is a problem, but making it
part of the machine vector would eliminate that chance.  One other nit,
there's a stray printk("."); in SN_SAL_IOIF_GET_DEVICE_DMAFLUSH_LIST.
Was that supposed to be in the #ifdef'd out code?  It might be nice to
use loglevels for these printks so you can see them w/o changing code.
Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel