[Xen-ia64-devel] Re: [patch] lindent dom_fw_foo code

[Alex Williamson <alex.williamson@xxxxxx>]

On Thu, 2007-05-24 at 17:46 +0200, Jes Sorensen wrote:
> Hi,
> 
> Guess a patch speaks a million words :)
> 
> This one Lindents the dom_fw_foo files to match the more reasonable
> formatting they had prior to being split up.
> 
> It reduces the overall file size by about 15% and makes it a lot easier
> to apply patches that were generated against dom_fw.c before the split.

   I strongly prefer Linux indentation style to Xen/BSD and my "fixing"
of indentation often shows my preference.  So far I've only insisted
that patches should follow the indentation style of the surrounding
code.  For new files, I've been happy to accept Linux style, but have a
hard time rejecting patches using BSD style simply because it's the
style the rest of Xen is based on.

   If we want to decide right now that anything under xen/arch/ia64 or
xen/include/asm-ia64 uses Linux style formatting, I'm all for it.  We
already have a significant amount of code from Linux which we can't
reformat to BSD or we'll lose all hope of ever updating it again.  I
also agree with the philosophy that 8 space tabs and 80 columns promotes
better code by naturally identifying where the nesting gets too deep.
I'll still require patches to match the style of the surrounding code,
but all new files should use Linux style and I'll accept patches like
this one that convert to Linux style.  Are there other opinions on this
before we set a precedent?  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel