RE: [Xen-ia64-devel] [PATCH] Fix vmx_vcpu_thash()

["Xu, Anthony" <anthony.xu@xxxxxxxxx>]

I agree with Kouya.

PAL_VPS_THASH is not used by far.

- Anthony


>-----Original Message-----
>From: Kouya Shimura [mailto:kouya@xxxxxxxxxxxxxx]
>Sent: 2007年6月12日 9:25
>To: Alex Williamson
>Cc: Xu, Anthony; tgingold@xxxxxxx; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>Subject: RE: [Xen-ia64-devel] [PATCH] Fix vmx_vcpu_thash()
>
>Hi,
>
>In guest Linux and Windows using short format VHPT,
>there is no performance degradation for this patch.
>So I wish it to be applied.
>(and besides my machine's PAL is 8.09)
>
>Even on latest PAL, the following patch is needed.
>     if(vpta.vf){
>         pval = ia64_call_vsa(PAL_VPS_THASH, vadr, vrr.rrval,
>                              vpta.val, 0, 0, 0, 0);
>-        pval = vpta.val & ~0xffff;
>     }else{
>         vhpt_offset=((vadr>>vrr.ps)<<3)&((1UL<<(vpta.size))-1);
>         pval = (vadr & VRN_MASK) |
>
>Thanks,
>Kouya
>
>Alex Williamson writes:
> > On Fri, 2007-06-08 at 15:23 +0800, Xu, Anthony wrote:
> > > Hi all,
> > >
> > > This bug has been fixed by PAL9.08.
> > > You need to update PAL to 9.08.
> >
> >   So is this patch needed?  We can't expect everyone to have the very
> > latest PAL and 9.08 is quite new.  I think something around PAL 7.31 was
> > what was available when Montecito shipped, so that probably needs to be
> > our baseline for hvm issues even though it doesn't have the VT-i
> > performance optimizations.  Thanks,
> >
> >     Alex
> >
> > --
> > Alex Williamson                             HP Open Source & Linux Org.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel