Re: [Xen-ia64-devel] code in vms_fault.c

[Jun Kamada <kama@xxxxxxxxxxxxxx>]

Hi Tristan-san,

I will reply in behalf of Doi-san who is the original sender of
following patch, maybe. 

It seems that the x86 code already have no limitation about getting
local_event.
I consider the limitation should be removed from ia64 code too. I would
like to post the patch to remove it in a few weeks.

-----
I consider that only removing the "if (v->vcpu_id == 0) {" clause is
not enough and additional code such like following are required. 
Therefore, I need a time to make the patch.

- Any VCPU can check event channel.
- One VCPU that first comes can set up the interrupt controller.

Your helpful advise is welcomed.
Thanks,


On Sat, 1 Sep 2007 07:58:13 +0200
Tristan Gingold <tgingold@xxxxxxx> wrote:

> Hi,
> 
> in vms_fault.c:leave_hypervisor_tail():
> 
>         if (v->vcpu_id == 0) {
>             unsigned long callback_irq =
>                 d->arch.hvm_domain.params[HVM_PARAM_CALLBACK_IRQ];
> 
>             if ( v->arch.arch_vmx.pal_init_pending ) {
>                 /*inject INIT interruption to guest pal*/
>                 v->arch.arch_vmx.pal_init_pending = 0;
>                 deliver_pal_init(v);
>                 return;
>             }
> 
>             /*
>              * val[63:56] == 1: val[55:0] is a delivery PCI INTx line:
>              *                  Domain = val[47:32], Bus  = val[31:16],
>              *                  DevFn  = val[15: 8], IntX = val[ 1: 0]
>              * val[63:56] == 0: val[55:0] is a delivery as GSI
>              */
>             if (callback_irq != 0 && local_events_need_delivery()) {
>                 /* change level for para-device callback irq */
>                 /* use level irq to send discrete event */
> 
> My question is why the local_event check is conditionned by v->vcpu_id == 0 ?
> 
> Thanks in advance,
> Tristan.
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel

Jun Kamada
Linux Technology Development Div.
Server Systems Unit
Fujitsu Ltd.
kama@xxxxxxxxxxxxxx



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel