[Xen-ia64-devel] [Patch][RFC] remove panic_domain in guest_write_eoi() for kexec on HVM

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi,

I thik the following panic_domain in guest_write_eoi() is not necessary,
because ia64_eoi() in linux is called without checikng in-service.

 515 void guest_write_eoi(VCPU *vcpu)
 516 {
 517     int vec;
 518 
 519     vec = highest_inservice_irq(vcpu);
 520     if ( vec == NULL_VECTOR ) 
 521         panic_domain(vcpu_regs(vcpu), "Wrong vector to EOI\n");
 522     VLSAPIC_INSVC(vcpu,vec>>6) &= ~(1UL <<(vec&63));
 523     VCPU(vcpu, eoi)=0;    // overwrite the data
 524     vcpu->arch.irq_new_pending=1;
 525     wmb();
 526 }

What do you think about it?

If we call kexec/kdump on HVM domain,
Xen call panic_domain. I made the following patch,
but I have never successed kexec/kdump yet.

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>

Best Regards,

Akio Takebe

Attachment: remove_panic_domain.patch
Description: Binary data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel