Re: [Xen-ia64-devel] [PATCH 0/23] [RFC] VTi domain save/restore

[tgingold@xxxxxxx]

Quoting Isaku Yamahata <yamahata@xxxxxxxxxxxxx>:

>
> Hi all.
> I've been working on IA64 HVM domain save/restore.
Impressive!

> Tristan.
> Could you elaborate on struct vcpu_guest_context_regs rbs_nat, rbs_rnat?
> The comment above them is somewhat vague.
> I heavily rewrote the rbs related part of getting/setting vcpu context.
> I'm not sure about them and I used only rbs_rnat.
rbs_rnat is clear.  rbs_nat seems to be useless.  As you know, these fields
were never set.  So you can remove rbs_nat.

> I haven't forgotten hvm domain dump-core fix. I need to implement
> HVM vcpu context save before fixing it.
Ok.

> - RSE (both PV and HVM domain)
>   The number of physical stacked general register(RSE.N_STACKED_PHYS)
>   isn't virtualized. Guest OS utilizes it via PAL_RSE_INFO call.
>   If the number of cpu where domain is saved/restored aren't same,
>   what should be supposed to do?
>   The SDM says only that the number is cpu implementation specific.
>   So the easiest way is to refuse restore.
>   Any thoughts/comments?
Refuse restore by default but have a flag to force it ?

>   struct opt_feature seems stable for save/restore ABI.
>   Or does someone else want to play with opt_feature hypercall?
Yes, new flags may be added in the future.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel