Re: [Xen-ia64-devel] [PATCH] implement some PAL procedures

[Tristan Gingold <tgingold@xxxxxxx>]

On Wed, Oct 31, 2007 at 06:09:12PM +0900, Isaku Yamahata wrote:
> On Wed, Oct 31, 2007 at 04:51:45PM +0900, Kouya Shimura wrote:
> Content-Description: message body text
> 
> > +       case PAL_BRAND_INFO:
> > +           if (in1 == 0) {
> > +                   char brand_info[128];
> > +                   status = ia64_pal_get_brand_info(brand_info);
> > +                   if (status == PAL_STATUS_SUCCESS)
> > +                           copy_to_user((void *)in2, brand_info, 128);
> 
> copy_to_user()'s in the pal emulator seem to be leftovers
> from pre xencomm.
> Although it is right to integrate xencomm into GFW, I'm not sure
> it's worthwhile...

Good point.  I think it is worthwhile as a missing TC entry will crash the
domain (and maybe the hypervisor).
Adding xencomm for PAL (and SAL if necessary) requires coordinated work
between GFW and domU stubs.
IMHO this is a security hole if the hypervisor can be crashed.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel