[Xen-ia64-devel] RE: [PATCH 5/5] Implement guest_os_type for ia64

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-11-28 at 14:36 +0800, Zhang, Xing Z wrote:
> I really directly use copy/parse , thx for collecting me.
> My purpose to use arch_setup for two reasons:
> 1. Do little change in common code.
> 2. I think building tools should not know much about how
> to set identify mapping. It only needs tell XEN which region 
> should be identify mapping. 
> Of course, your implantation is more flexible, both method are ok for me.  

Hi Wing,

   Thanks for reviewing and confirming the UC vs WB change.  The
arch_setup does reduce the change to common code, but it adds an
architecture specific flag to a field that is currently architecture
neutral.  There are already architecture specific domctls, and other
architectures could choose to use the set_opt_feature we've defined with
different structure fields.  It seems more natural and tunable to me to
let the builder code specifically set the identity mappings.  I like
that the entire opt_feature interface is exposed and we can tune it and
experiment without rebooting a new hypervisor (at least for the set of
optimizations we've defined so far).  Anyone else have a strong opinion?
Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel