[Xen-ia64-devel] [PATCH 6/12] vti fault handler clean up take 2: clean up VMX_DO_SAVE_MIN

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

# HG changeset patch
# User yamahata@xxxxxxxxxxxxx
# Date 1196658611 -32400
# Node ID 9a0b43566ea1b5fd8f136a4b823d001d4988f94e
# Parent  604dc1f4779c90468d3a9a161afa1dcabf279400
clean up VMX_DO_SAVE_MIN.
- p15 was set twice with same condition
- r1 was set to r21 via r16. using r16 doesn't make sense.
  direct set r1 to r21.
PATCHNAME: clean_up_vmx_do_save_min

Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>

diff -r 604dc1f4779c -r 9a0b43566ea1 xen/arch/ia64/vmx/vmx_minstate.h
--- a/xen/arch/ia64/vmx/vmx_minstate.h  Mon Dec 03 14:10:10 2007 +0900
+++ b/xen/arch/ia64/vmx/vmx_minstate.h  Mon Dec 03 14:10:11 2007 +0900
@@ -107,7 +107,6 @@
  */
 
 #define VMX_DO_SAVE_MIN(COVER,SAVE_IFS,EXTRA)                                  
         \
-    VMX_MINSTATE_GET_CURRENT(r16);      /* M (or M;;I) */                      
         \
     mov r27=ar.rsc;                     /* M */                                
         \
     mov r20=r1;                         /* A */                                
         \
     mov r25=ar.unat;                    /* M */                                
         \
@@ -122,7 +121,7 @@
     ;;                                                                         
         \
 (p6)br.spnt.few vmx_panic;                                                     
         \
     tbit.z p0,p15=r29,IA64_PSR_I_BIT;                                          
         \
-    mov r1=r16;                                                                
         \
+    VMX_MINSTATE_GET_CURRENT(r1);      /* M (or M;;I) */                       
         \
     /*    mov r21=r16;  */                                                     
         \
     /* switch from user to kernel RBS: */                                      
         \
     ;;                                                                         
         \
@@ -137,7 +136,6 @@
     st8 [r16]=r29;      /* save cr.ipsr */                                     
         \
     ;;                                                                         
         \
     lfetch.fault.excl.nt1 [r17];                                               
         \
-    tbit.nz p15,p0=r29,IA64_PSR_I_BIT;                                         
         \
     mov r29=b0                                                                 
         \
     ;;                                                                         
         \
     adds r16=PT(R8),r1; /* initialize first base pointer */                    
         \

Attachment: 16507_9a0b43566ea1_clean_up_vmx_do_save_min.patch
Description: Text Data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel