[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-ia64-devel] [PATCH] [ia64] kexec: Use error path if crash region range can't be accessed
Although the error handling path in xen_machine_kexec_setup_resource() is somewhat minmal, it ought to be used if HYPERVISOR_kexec_op() fails when getting the crash kernel region, as this indicates that an error occured, not that the crash kernel region is empty. Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx> --- Alex: This is a fairly trivial fix, please consider merging independantly of other kexec patches Index: linux-2.6.18-xen.hg/drivers/xen/core/machine_kexec.c =================================================================== --- linux-2.6.18-xen.hg.orig/drivers/xen/core/machine_kexec.c 2008-02-25 14:18:40.000000000 +0900 +++ linux-2.6.18-xen.hg/drivers/xen/core/machine_kexec.c 2008-02-25 14:19:00.000000000 +0900 @@ -85,7 +85,7 @@ void __init xen_machine_kexec_setup_reso range.range = KEXEC_RANGE_MA_CRASH; if (HYPERVISOR_kexec_op(KEXEC_CMD_kexec_get_range, &range)) - return; + goto err; if (range.size) { crashk_res.start = range.start; _______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-ia64-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |