Re: [Xen-ia64-devel] [PATCH] fix gmfn_to_mfn

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Fri, May 09, 2008 at 08:54:59PM +0900, Kouya Shimura wrote:
Content-Description: message body text
> Isaku Yamahata writes:
> > Probably is_hvm_domain() check should be moved down.
> > Could you please check the attached patches?
> 
> Umm.., we might be careful in changing lookup_domain_mpa()
> because there is so much use of lookup_domain_mpa().
> 
> For example, vmx_hpw_miss() in xen/arch/ia64/vmx/vmx_fault.c:
> ============================================================
>             pte = lookup_domain_mpa(v->domain, gppa, NULL);
>             if (pte & _PAGE_IO) {
>                 if (misr.sp)
>                     panic_domain(NULL, "ld.s on I/O page not with UC attr."
>                                  " pte=0x%lx\n", data->page_flags);
> ============================================================
> Windows often uses ld.s and the guest can be killed due to pte=-1.
> 
> For the present, could you apply the attached patch?
> It must be harmless.

Okay.
The above comment implies that the caller of lookup_domain_mpa()
for hvm domain should be revised, doesn't it?

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel