Re: [Xen-ia64-devel] [PATCH] remove warnings in replace_grant_host_mapping()

[Alex Williamson <alex.williamson@xxxxxx>]

On Tue, 2008-05-13 at 11:56 +0900, Isaku Yamahata wrote:
> [IA64] remove warnings in replace_grant_host_mapping()

> diff -r b52e75f2416a xen/arch/ia64/xen/mm.c
> --- a/xen/arch/ia64/xen/mm.c  Mon May 12 16:23:54 2008 +0900
> +++ b/xen/arch/ia64/xen/mm.c  Mon May 12 16:30:46 2008 +0900
> @@ -2191,7 +2191,7 @@
>      struct page_info* page = mfn_to_page(mfn);
>      struct page_info* new_page = NULL;
>      volatile pte_t* new_page_pte = NULL;
> -    unsigned long new_page_mfn;
> +    unsigned long new_page_mfn = INVALID_MFN;
>  
>      if (new_gpaddr) {
>          new_page_pte = lookup_noalloc_domain_pte_none(d, new_gpaddr);
> @@ -2211,7 +2211,7 @@
>                               "new_gpaddr 0x%lx mfn 0x%lx\n",
>                               __func__, gpaddr, mfn, new_gpaddr, 
> new_page_mfn);
>                      new_page = NULL; /* prevent domain_put_page() */
> -                    goto out;
> +                    goto out_nomsg;

These could really just be 'return GNTST_general_error;' since there's
no other cleanup, then you could avoid a goto.

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel