Re: [Xen-merge] i386 subarch

["Martin J. Bligh" <mbligh@xxxxxxxxxx>]

--Chris Wright <chrisw@xxxxxxxx> wrote (on Wednesday, August 03, 2005 18:43:16 
-0700):

> * Chris Wright (chrisw@xxxxxxxx) wrote:
>> Still to be done:
>> 
>> 1) Move core bits (non arch specific) over to drivers/xen/core
> 
> This is done.
> 
>> 2) Move core headers (non arch specific) to linux/xen
> 
> This is done (I think a few bits may still need to move)
> 
>> 3) refactor arch specific source out of arch/i386/mach-xen/ back into
>> arch/i386/ with necessary bits left in arch/i386/mach-xen/
>> 4) lots of general cleanup
>> 5) whatever i'm forgetting since it's late
> 
> http://kernel.org/pub/linux/kernel/people/chrisw/xen/xen-i386-subarch.patch-2.gz
> 
> This one actually boots dom0 (scary thought ;-).  Ian had suggested
> possibly making a vanilla linux tree repo to work against, and I'm not
> yet sure if that's the best way or not.  Perhaps this could overlay in
> the sparse tree.

Wow, you're a machine. That's a pretty stunning amount of work.

One quick question, are you working against virgin 2.6.12, or bleeding
edge git tree? Is important we all work against the same thing, whatever
that is ... will follow whatever you did, just need to know.


I took a quick look through it, am reluctant to criticise anything
under the circumstances, but still ... some specifics ... 

Some of the files look very surgically cut out; some of them look to
have been copied over, and then a few bits edited ... I presume you
actually know this already, but for what it's worth - seems to be 
quite a bit of duplication (whole duplicated functions) in: 

arch/i386/mach-xen/kernel/cpu/common.c
arch/i386/mach-xen/kernel/i386_ksyms.c
arch/i386/mach-xen/kernel/io_apic.c
arch/i386/mach-xen/kernel/ioport.c
arch/i386/mach-xen/kernel/irq.c
arch/i386/mach-xen/kernel/ldt.c
arch/i386/mach-xen/kernel/mpparse.c
arch/i386/mach-xen/kernel/pci-dma.c
arch/i386/mach-xen/kernel/process.c
arch/i386/mach-xen/kernel/setup.c
arch/i386/mach-xen/kernel/signal.c
arch/i386/mach-xen/kernel/syscall_table.S 
arch/i386/mach-xen/kernel/time.c 
arch/i386/mach-xen/kernel/traps.c
arch/i386/mach-xen/mm/fault.c
arch/i386/mach-xen/mm/highmem.c
arch/i386/mach-xen/mm/init.c
arch/i386/mach-xen/mm/ioremap.c
arch/i386/mach-xen/mm/pgtable.c
arch/i386/mach-xen/pci/irq.c

Might be useful to run diff in reverse somehow, and find all the
commonalities between the two sections of code. I'll see if I can
figure a way to do that. 

So what do we want to do? Break it up by filename, and see if we
can get several people to clean up a few files each? Tis a fair 
amount of work to do. Will help if we can get the patch to as small
as possible, and show as little duplication as possible to miminize
ongoing maintainance for everyone (including, but not limited to
the Xen people).


_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge