Re: [Xen-merge] [PATCH] merge i386's agp.h

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx> 20.12.05 19:01 >>>
>On Tue, Dec 20, 2005 at 03:15:00PM +0100, Jan Beulich wrote:
> Subject says it all.
>
>I'm not sure that is the right approch. Adding ifdef all over [1]
>has never been well accepted by kernel people ...

I know.

>But it look backwards from Chris' approch to split files into mach
and
>generic (especially floppy.h)
>(which is, imho not nicer on a certain POV.)
>
>Maybe a mix of the two would be the `cleanest' [2] solution.

That is what I'm aiming towards. If more splitting is needed, this can
always be done in a second round. But we should get started somehow...

>[1] there's not that much ifdef so "all over" is a bit strong here
...
>[2] I'm afraid there's no such thing here ..

Jan

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge