Re: [Xen-merge] questions (resend)

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>> include/asm-i386/mach-xen/asm/setup.h
>> - What is the 'unsigned long long' override for PFN_PHYS good for
(and
>>   if for anything, why isn't standard Linux in need of this in PAE
>>   mode)?
>
>It must have got added at some point to fix a problem on >4GB boxes, 
>but now I can't see any use of PFN_PHYS where the result can
reasonably 
>be larger than 4GB. Perhaps the offending usage got removed. I think 
>this modification to PFN_PHYS shouldn't get merged.

I actually disagree after a second inspection: At least the use in the
call to add_memory_region() (in
include/asm-i386/mach-xen/setup_arch_post.h) doesn't work right without
that cast. I will, however, remove the cast in the header anyway and
rather add one in that place.

Jan

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge